Add Chromium versions for api.Response.Response.body_param_null #13076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds real values for Chromium (Chrome, Opera, Samsung Internet, WebView Android) for the `Response.body_param_null` member of the `Response` API, based upon commit history and date. Commit: https://source.chromium.org/chromium/chromium/src/+/3cef67a6ce8923e59bd08a7e4f04d64f08e89edd Additionally, this PR renames this parameter to `body_parameter_optional` for better consistency.
github-actions
bot
added
the
data:api
This reverts commit d8db63f.
jpmedley
reviewed
Oct 28, 2021
| @@ -194,15 +194,15 @@ | |||
| } | |||
| } | |||
| }, | |||
| "body_param_null": { | |||
| "body_parameter_optional": { | |||
There was a problem hiding this comment.
My knowledge of BCD has obviously gotten out of date. Would you mind sending me an explanation of how this resolves to the key on the MDN page (browser-compat: api.Response.body) when there's no part of the JSON tree named "body"?
There was a problem hiding this comment.
It doesn't resolve to api.Response.body. This key is talking about the body parameter passed into the Response() constructor!
jpmedley
approved these changes
Oct 28, 2021
ddbeck
added a commit
to ddbeck/browser-compat-data
that referenced
this pull request
Nov 2, 2021
ddbeck
added a commit
that referenced
this pull request
Nov 2, 2021
* Bump version to v4.0.9 * Set release date * Add release note for #12795 * Add release note for #13006 * Add release note for #13136 * Add release note for #13076 * Add release note for #13216 * Add release note for #11924 * Add release note for #13143 * Undo list of one item * Hoist known issues * Add stats * Fix compare link
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds real values for Chromium (Chrome, Opera, Samsung Internet, WebView Android) for the
Response.body_param_nullmember of theResponseAPI, based upon commit history and date.Commit: https://source.chromium.org/chromium/chromium/src/+/3cef67a6ce8923e59bd08a7e4f04d64f08e89edd (commit was before the Response API was exposed)
Additionally, this PR renames this parameter to
body_parameter_optionalfor better consistency.